Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 2020 run sonarqube #2024

Merged
merged 2 commits into from
Jan 27, 2022
Merged

Feature 2020 run sonarqube #2024

merged 2 commits into from
Jan 27, 2022

Conversation

hsoh-u
Copy link
Collaborator

@hsoh-u hsoh-u commented Jan 25, 2022

Expected Differences

  • Do these changes introduce new tools, command line arguments, or configuration file options? [No]

    If yes, please describe:

  • Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]

    If yes, please describe:

Pull Request Testing

  • Describe testing already performed for these changes:

    • Configured the crontab under "met_test"account
    • Run the SonarQube scanning nightly
    • Checkout feature_2020_run_sonarqube branch
    • run <MET_checkout_dir>/scripts/sonarqube/run_nightly.sh develop
  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

Check the daily scanning result at http://mandan.rap.ucar.edu:9000/dashboard?id=org.sonarqube%3AMET_NB

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes or No]

  • Do these changes include sufficient testing updates? [No]

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Please complete this pull request review by [Fill in date].

Pull Request Checklist

See the METplus Workflow for details.

  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select Linked issues with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@hsoh-u hsoh-u added the component: build process Build process issue label Jan 25, 2022
@hsoh-u hsoh-u added this to the MET 10.1.0 milestone Jan 25, 2022
@hsoh-u hsoh-u linked an issue Jan 25, 2022 that may be closed by this pull request
21 tasks
Copy link
Collaborator

@JohnHalleyGotway JohnHalleyGotway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve of these changes. I see this adds logic to run SonarQube on seneca. I see the results displayed at http://mandan.rap.ucar.edu:9000/dashboard?id=org.sonarqube%3AMET_develop_NB. Looks to me like its working! Thanks.

@JohnHalleyGotway JohnHalleyGotway removed the component: build process Build process issue label Jan 26, 2022
@hsoh-u hsoh-u merged commit cfb4759 into develop Jan 27, 2022
@JohnHalleyGotway JohnHalleyGotway deleted the feature_2020_run_sonarqube branch March 17, 2022 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automate calls to the SonarQube static code analysis tool in the nightly build
2 participants